Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_brand: Migration to 18.0 #215

Merged
merged 74 commits into from
Jan 14, 2025

Conversation

xaviedoanhduy
Copy link

supersede: #211
add blacklist port: #214

bguillot and others added 30 commits December 4, 2024 16:08
* add smart button, move menu to a more visible position.
* show brand in product.template kanban and tree views.
* show brand in product variant kanban and tree views.
* add product_brand kanban view.
* update module's README and manifest file.
* Search and group by brand for both product.product and product.template.
* Convert model to new APIs.
* Refactor products_count computation using product_ids one2many field.
* Add public read access to product.brand (fixes 403 error on webshop for public user).
* Make brand name required.
Old form view was out of order: form blocks misaligned, because it was
not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the
data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings)

Translation: product-attribute-11.0/product-attribute-11.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364)

* Make the logo always the same width (64px).
* Remove the description (200 first caracters). Not relevant for a configuration model.
* Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/
Currently translated at 37.5% (9 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/
Copy link

@kobros-tech kobros-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by unit testing and implementing

@@ -1 +1,2 @@
The migration of this module from 16.0 to 17.0 was financially supported by Camptocamp.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the first sentence regarding 16.0 to 17.0 migration, and keep only the new one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it to give the most logical output.

@bosd bosd mentioned this pull request Jan 6, 2025
2 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2025-01-14_15-35

@rvalyi
Copy link
Member

rvalyi commented Jan 14, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-215-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6966de6. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit b24875f into OCA:18.0 Jan 14, 2025
7 checks passed
@xaviedoanhduy xaviedoanhduy deleted the 18.0-mig-product_brand branch January 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.